Skip to content

Conversation

@atharvashahane28
Copy link
Collaborator

@atharvashahane28 atharvashahane28 commented Sep 24, 2025

This PR will:

  • Create config environment and assign default values to it.
  • Move most of the items in in globals.R to config by adding a prefix config$ when assigning and retrieving them. If there's any chance it would change in a different deployment it should be in config and not defined as a global constant in the package.
  • Move state variables created by set_s3_config and retrieved by get_s3_config to the config environment. Replace assign() with config$option <- .
  • Add Items in config to set:
    • local_temp_path
    • log_file_path,
    • log (flag to turn logging on and off)
  • Update logging to honor log_file_path and log
  • Update flow to honor local_temp_path
  • Move set_s3_config and get_s3_config into s3_config.R (from flow.R)
  • Set all list items as variables in config using config$...

@atharvashahane28 atharvashahane28 self-assigned this Sep 24, 2025
@atharvashahane28 atharvashahane28 linked an issue Sep 24, 2025 that may be closed by this pull request
12 tasks
@atharvashahane28 atharvashahane28 merged commit 47eb3ac into main Sep 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move all state variables into environment within package

2 participants